fix(config): accept full Go package paths in packages[*].binaries ai:claude-sonnet-4-6 #68

Merged

heiko merged 1 commit from fix/67-packages-binaries-accept-full-path into master

2026-05-22 00:46:00 +02:00

heiko commented

2026-05-22 00:29:22 +02:00

Owner

Fixes #67.

Users naturally mirror the build.commands path form (cmd/foo) in
packages[*].binaries. Previously this caused a confusing doctor error
and silently dropped binaries from packages at runtime.

Changes

internal/config/packages.go — normalize Binaries entries to basenames
in PackagesSpec.UnmarshalYAML; both cmd/foo and foo are accepted
internal/config/validation.go — knownBinary uses path.Base on both
sides, covering code paths that bypass YAML (tests, future callers)
internal/config/packages_test.go — TestValidatePackages_FullPathBinary
README.md — note both forms are accepted

(co)authored by ai:claude-sonnet-4-6

Fixes #67. Users naturally mirror the `build.commands` path form (`cmd/foo`) in `packages[*].binaries`. Previously this caused a confusing `doctor` error and silently dropped binaries from packages at runtime. ## Changes - `internal/config/packages.go` — normalize `Binaries` entries to basenames in `PackagesSpec.UnmarshalYAML`; both `cmd/foo` and `foo` are accepted - `internal/config/validation.go` — `knownBinary` uses `path.Base` on both sides, covering code paths that bypass YAML (tests, future callers) - `internal/config/packages_test.go` — `TestValidatePackages_FullPathBinary` - `README.md` — note both forms are accepted (co)authored by ai:claude-sonnet-4-6

heiko added 1 commit

2026-05-22 00:29:22 +02:00

fix(config): accept full Go package paths in packages[*].binaries ai:claude-sonnet-4-6 2be1b6d0f4

Users naturally mirror the build.commands path form (cmd/foo) in
packages[*].binaries. Previously this caused a confusing doctor error
and silently dropped binaries from packages at runtime.

Fix: normalize binaries entries to basenames in PackagesSpec.UnmarshalYAML
so both cmd/foo and foo are accepted transparently. Also update knownBinary
in validation.go to use path.Base on both sides, covering code paths that
construct config.Package without going through YAML.

Closes #67.

heiko commented

2026-05-22 00:36:39 +02:00

Author

Owner

PASS: go test ./... passed.

heiko merged commit 449fd87797 into master

2026-05-22 00:46:00 +02:00

heiko deleted branch fix/67-packages-binaries-accept-full-path

2026-05-22 00:46:00 +02:00

heiko referenced this pull request from a commit

2026-05-22 00:46:00 +02:00

Merge pull request 'fix(config): accept full Go package paths in packages[*].binaries ai:claude-sonnet-4-6' (#68) from fix/67-packages-binaries-accept-full-path into master