heiko/fj
1
0
Fork 0
Code Issues 9 Pull requests Projects Releases 12 Packages Wiki Activity Actions

pre-fill canonical label names in editor template #22

Merged
heiko merged 5 commits from fix/20-autocomplete-label-create into master 2026-05-17 22:05:20 +02:00
Conversation 1 Commits 5 Files changed 4 +103 -4
heiko commented 2026-05-17 21:36:24 +02:00
Owner
Copy link

Fixes #20.

Summary

  • Add resolveLabelsToNames helper that maps raw --label input to canonical names using the existing fuzzy matching logic
  • Call it in issue create and pr create before building the editor template, so --label bu shows Bug in the editor instead of bu
  • Ambiguous or unknown inputs are kept as-is and handled by the existing post-edit resolveLabels call

Test plan

  • fj issue create --label bu — editor opens with label: Bug
  • fj pr create --label enh — editor opens with label: Enhancement
  • fj issue create --label xyz — editor opens with label: xyz, error surfaces fast
  • go test ./... passes
Fixes #20. ## Summary - Add `resolveLabelsToNames` helper that maps raw `--label` input to canonical names using the existing fuzzy matching logic - Call it in `issue create` and `pr create` before building the editor template, so `--label bu` shows `Bug` in the editor instead of `bu` - Ambiguous or unknown inputs are kept as-is and handled by the existing post-edit `resolveLabels` call ## Test plan - [x] `fj issue create --label bu` — editor opens with `label: Bug` - [x] `fj pr create --label enh` — editor opens with `label: Enhancement` - [x] `fj issue create --label xyz` — editor opens with `label: xyz`, error surfaces fast - [x] `go test ./...` passes
fix: pre-fill canonical label names in editor template
Some checks failed
mod-nag (Push) / mod-nag (push) Has been cancelled
Details
b8d5045193
 
When --label is passed to issue/pr create, resolve the raw input to
its canonical name before opening the editor, so the template shows
"Bug" instead of "bu". Ambiguous or unknown inputs are kept as-is and
resolved (or rejected) after the editor closes as before.

Fixes #20.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
heiko force-pushed fix/20-autocomplete-label-create from b8d5045193
Some checks failed
mod-nag (Push) / mod-nag (push) Has been cancelled
Details
to 99553f48d9
Some checks failed
mod-nag (Push) / mod-nag (push) Has been cancelled
Details
2026-05-17 21:42:00 +02:00 Compare
refactor: extract labelNames helper to avoid duplicate slice building
Some checks failed
mod-nag (Push) / mod-nag (push) Has been cancelled
Details
29863681e3
 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
heiko commented 2026-05-17 21:53:25 +02:00
Author
Owner
Copy link

looks good. checkLabels before the editor is the right call — fail fast on typos. labelNames helper avoids the duplicate slice build in resolveLabels. TDD structure is clean.

looks good. `checkLabels` before the editor is the right call — fail fast on typos. `labelNames` helper avoids the duplicate slice build in `resolveLabels`. TDD structure is clean.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: error on unknown --label before opening editor
Some checks failed
mod-nag (Push) / mod-nag (push) Has been cancelled
Details
7f1e06bcac
 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
heiko merged commit 4442e363af into master 2026-05-17 22:05:20 +02:00
heiko deleted branch fix/20-autocomplete-label-create 2026-05-17 22:05:20 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
nagonag
Automated dependency scan finding

  
nagonag/ignore
Ignore this nagonag finding

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
nagonag
nagonag/ignore
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
heiko/fj!22
No description provided.