heiko/fj
1
0
Fork 0
Code Issues 9 Pull requests Projects Releases 12 Packages Wiki Activity Actions

prefer push URL when detecting remote, cope with SSH forms #27

Merged
heiko merged 3 commits from fix/26-ssh-git-repo-urls into master 2026-05-18 19:37:17 +02:00
Conversation 3 Commits 3 Files changed 2 +12 -2
heiko commented 2026-05-18 19:05:42 +02:00
Owner
Copy link

Fixes #26.

Summary

  • Detect() now tries git remote get-url --push first; falls back to
    the fetch URL if the push URL can't be parsed
  • When no explicit push URL is configured, --push returns the fetch
    URL, so the common case is unaffected
  • Added test rows for ssh:// and SCP-style URLs without .git suffix

Notes

API-time retry (if the derived HTTPS endpoint fails, retry with the
other URL) is out of scope here — that's a follow-up.

Test plan

  • go test ./internal/repo/... passes (all 7 URL parse cases)
  • Set an SSH push URL (git remote set-url --push origin git@…),
    run fj issues — should resolve correctly
Fixes #26. ## Summary - `Detect()` now tries `git remote get-url --push` first; falls back to the fetch URL if the push URL can't be parsed - When no explicit push URL is configured, `--push` returns the fetch URL, so the common case is unaffected - Added test rows for `ssh://` and SCP-style URLs without `.git` suffix ## Notes API-time retry (if the derived HTTPS endpoint fails, retry with the other URL) is out of scope here — that's a follow-up. ## Test plan - [x] `go test ./internal/repo/...` passes (all 7 URL parse cases) - [x] Set an SSH push URL (`git remote set-url --push origin git@…`), run `fj issues` — should resolve correctly
fix: prefer push URL when detecting remote, cope with SSH forms
All checks were successful
nagonag (Push) / nagonag (push) Successful in 2m31s
Details
3caa37c018
 
When a remote has both a fetch URL and an explicit push URL, use the
push one. Fall back to the fetch URL if the push URL can't be parsed.
"git remote get-url --push" returns the fetch URL when no pushurl is
configured, so the common case is unaffected.

Add test coverage for ssh:// and SCP-style URLs without .git suffix.

Fixes #26.

Co-Authored-By: claude-sonnet-4-6 <noreply@anthropic.com>
ius:ai:claude-sonnet-4-6
forgejo-actions commented 2026-05-18 19:07:22 +02:00
Copy link

PASS: go test ./... passed.

PASS: go test ./... passed.
simplify: trim overexplained comment in Detect
All checks were successful
nagonag (Push) / nagonag (push) Successful in 2m32s
Details
813859cfc2
 
Co-Authored-By: claude-sonnet-4-6 <noreply@anthropic.com>
ius:ai:claude-sonnet-4-6
forgejo-actions commented 2026-05-18 19:29:16 +02:00
Copy link

PASS: go test ./... passed.

PASS: go test ./... passed.
fix: restore insteadOf note, add TODO for Detect integration test
Some checks failed
nagonag (Push) / nagonag (push) Has been cancelled
Details
f153f2b8f3
 
Co-Authored-By: claude-sonnet-4-6 <noreply@anthropic.com>
ius:ai:claude-sonnet-4-6
forgejo-actions commented 2026-05-18 19:34:34 +02:00
Copy link

PASS: go test ./... passed.

PASS: go test ./... passed.
heiko force-pushed fix/26-ssh-git-repo-urls from f153f2b8f3
Some checks failed
nagonag (Push) / nagonag (push) Has been cancelled
Details
to ef5b368901
All checks were successful
nagonag (Push) / nagonag (push) Successful in 1m33s
Details
2026-05-18 19:34:50 +02:00 Compare
heiko merged commit ead03c3a46 into master 2026-05-18 19:37:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
nagonag
Automated dependency scan finding

  
nagonag/ignore
Ignore this nagonag finding

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
nagonag
nagonag/ignore
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
heiko/fj!27
No description provided.