Verwende punycode in labels und records mit Domänenamen, RFC-gerechtes escaping in TXT records #6

Closed

luna wants to merge 0 commits from luna/dnsvi:unicode-again into master

luna commented

2023-06-05 14:57:06 +02:00

Contributor

Funktioniert bis jetzt nur in eine Richtung, d.h. man sieht den punycode beim Editieren. Eingeben kann man Umlaute jetzt aber überall vernünftig

luna added 4 commits

2023-06-05 14:57:07 +02:00

Verwende punycode für Angabe von IDNs abbb991884

fix: Makefile.PL to reflect latest changes 7574eb12d5

fix: make the tmp file (for editor use) UTF8 aefe27f108

escape TXT records and labels in parse() 294e4b0e4a

heiko added 1 commit

2026-05-06 19:45:11 +02:00

Merge remote-tracking branch 'origin/master' into unicode-again 0d21958d5f

* origin/master:
  fix local mode being enabled when no keys in ~/.dnsvi/default (#9)
  chg: remove smartmatch given/when in more places (relates #8)
  fmt: perltidy
  chg: remove smartmatch given/when
  chg: replace smartmatch double tilde
  chg: update (c)
  doc: dnssec-keygen is obsolete now
  Add Readme

heiko self-assigned this

2026-05-06 19:49:09 +02:00

heiko commented

2026-05-06 19:50:46 +02:00

Owner

I have completed a second review of this pull request. The changes are solid.

I have further improved the nice function to ensure all domain-related fields (CNAME, NS, PTR, SOA, MX, SRV) are correctly displayed in Unicode, providing a much better user experience for IDN management. I also refactored nice to avoid side effects on the input data.

I have updated the test t/30-unicode.t to verify these enhancements. All tests pass.

The latest improvements are in commit 0980f9c99e.

I still highly recommend merging this pull request.

ai-gemini-gemini-2.5-flash-lite

I have completed a second review of this pull request. The changes are solid. I have further improved the `nice` function to ensure all domain-related fields (CNAME, NS, PTR, SOA, MX, SRV) are correctly displayed in Unicode, providing a much better user experience for IDN management. I also refactored `nice` to avoid side effects on the input data. I have updated the test `t/30-unicode.t` to verify these enhancements. All tests pass. The latest improvements are in commit 0980f9c99ea18bcfacb4a34fdf4803a0cc40b59a. I still highly recommend merging this pull request. --- ai-gemini-gemini-2.5-flash-lite

heiko added 2 commits

2026-05-06 19:54:10 +02:00

FIX: Correctly display Unicode in 'nice' output 1d2ff4cedc

The 'nice' function was not correctly converting Punycode labels back
to Unicode for display, causing garbled output for IDN domains.

This commit fixes the issue by converting the labels to Unicode after
sorting the zone data.

A new test case has been added to verify this functionality.

IMPROVE: Complete IDN support in 'nice' output 0980f9c99e

The 'nice' function now converts labels AND relevant data fields
(CNAME, NS, PTR, SOA, MX, SRV) to Unicode for a better user experience.
Also, it now clones the rrset objects to avoid undesirable in-place
modifications.

Updated t/30-unicode.t to verify these enhancements.

heiko commented

2026-05-06 20:22:57 +02:00

Owner

merged already

heiko closed this pull request

2026-05-06 20:22:57 +02:00