fix local mode being enabled when no keys in ~/.dnsvi/default #9

luna · 2025-11-25T15:12:29+01:00

luna commented

2025-11-25 15:12:29 +01:00

If no key files are found in ~/.dnsvi/default/, dnsvi forcibly enabled local mode, but this is undesirable when a key is specified via the -k option.

Instead enable local mode only if no keys were found, and no key is specified.

If no key files are found in `~/.dnsvi/default/`, dnsvi forcibly enabled local mode, but this is undesirable when a key is specified via the `-k` option. Instead enable local mode only if no keys were found, **and** no key is specified.

luna added 1 commit

2025-11-25 15:12:30 +01:00

fix local mode being enabled when no keys in ~/.dnsvi/tsig/ 79e9bb6a48

heiko requested review from heiko

2025-11-25 15:15:25 +01:00

heiko requested changes

2025-11-25 16:17:49 +01:00

Dismissed

bin/dnsvi Outdated

					
				@ -24,3 +24,2 @@

				        local => undef,

				        key   => (grep { -f } glob "$ENV{HOME}/.dnsvi/default/*key")[0]

				          // (undef, local => 1),

				        key   => (grep { -f } glob "$ENV{HOME}/.dnsvi/default/*key")[0] // undef,

We should implement a way to specify the key location directly. E.g.:

implict in .dnsvi/... if used w/o / in the key file name
explicit in the filesystem, if the key file name contains /

We should implement a way to specify the key location *directly*. E.g.: - implict in `.dnsvi/...` if used w/o `/` in the key file name - explicit in the filesystem, if the key file name contains `/`

@heiko wrote in #9 (comment):

We should implement a way to specify the key location directly. E.g.:
* implict in `.dnsvi/...` if used w/o `/` in the key file name

* explicit in the filesystem, if the key file name contains `/`

The value passed to -k is a normal, cwd-relative path. So I'm not sure what you mean? The grep { -f } ... construct tries to find a default key to use if no -k flag is used.

@heiko wrote in https://forgejo.schlittermann.de/IUS/dnsvi/pulls/9#issuecomment-2806: > We should implement a way to specify the key location _directly_. E.g.: > > * implict in `.dnsvi/...` if used w/o `/` in the key file name > > * explicit in the filesystem, if the key file name contains `/` The value passed to `-k` is a normal, cwd-relative path. So I'm not sure what you mean? The `grep { -f } ...` construct tries to find a *default* key to use if no `-k` flag is used.