Log hash/name and reason of removal for removed files #65

Manually merged

heiko merged 4 commits from fix/44-log-removal-details into master

2026-07-21 11:55:45 +02:00

heiko commented

2026-05-27 17:49:08 +02:00

Owner

Log key (UUID), filename, and reason whenever a file is removed.

remove.go: log key=<uuid> name="<filename>" by=<user> reason=manual on manual removal; properly handle FindFile errors (return 404)
store.go Clean(): promote debug-only messages to log.Printf with structured fields: key, name, reason (info-expired / upload-expired)

Fixes #44

Log key (UUID), filename, and reason whenever a file is removed. - `remove.go`: log `key=<uuid> name="<filename>" by=<user> reason=manual` on manual removal; properly handle FindFile errors (return 404) - `store.go` Clean(): promote debug-only messages to `log.Printf` with structured fields: key, name, reason (info-expired / upload-expired) Fixes #44

heiko added 1 commit

2026-05-27 17:49:08 +02:00

Log hash/name and reason of removal for removed files d3b5f23242

- remove.go: log key, filename, user, and reason=manual on manual removal;
  handle FindFile errors properly (return 404)
- store.go Clean(): promote debug messages to log.Printf with structured
  fields: key, name, reason (info-expired / upload-expired)

Fixes #44

heiko requested review from mf

2026-05-27 17:49:50 +02:00

heiko added 1 commit

2026-05-27 17:53:08 +02:00

Log: quote user field, add area to cleanup messages e725507575

- remove.go: use %q for by= field (safe if username contains spaces)
- store.go Clean(): add area= field so expired-file logs identify the owner

heiko added 1 commit

2026-07-21 11:11:36 +02:00

Merge branch 'master' into fix/44-log-removal-details 0d5cc9d8d7

heiko referenced this pull request from a commit

2026-07-21 11:34:31 +02:00

fix: make removal logs reflect completed operations ai:claude-opus-4.6

heiko added 1 commit

2026-07-21 11:34:31 +02:00

fix: make removal logs reflect completed operations ai:claude-opus-4.6 39f35da03c

Address review findings for PR #65:

- log manual and cleanup removals only after they succeed
- return HTTP 500 when manual purge fails instead of redirecting as success
- log successful download claims with reason=download
- handle corrupt or unreadable metadata during cleanup instead of acting on a zero-value File
- quote all structured fields and errors to prevent forged log lines
- add regression coverage for manual/download logs, invalid metadata, both cleanup expiry paths, and failed cleanup removal

heiko self-assigned this

2026-07-21 11:46:07 +02:00

heiko referenced this pull request from a commit

2026-07-21 11:52:49 +02:00

fix: make removal logs reflect completed operations ai:claude-opus-4.6

heiko force-pushed fix/44-log-removal-details from 39f35da03c to 03e8465149

nagonag (Push) / nagonag (push) Successful in 3m36s

Details

2026-07-21 11:52:49 +02:00

Compare

heiko manually merged commit 03e8465149 into master

2026-07-21 11:55:45 +02:00